Centralize Redis Client Usage and Add Caching in LeaderboardService#115
Merged
phertyameen merged 1 commit intoMindBlockLabs:mainfrom Jul 28, 2025
Merged
Centralize Redis Client Usage and Add Caching in LeaderboardService#115phertyameen merged 1 commit intoMindBlockLabs:mainfrom
phertyameen merged 1 commit intoMindBlockLabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a singleton Redis client via a global
RedisModuleand integrates it into the existingLeaderboardServiceto enable caching of leaderboard queries. This improves performance by reducing redundant database queries and ensures consistent Redis usage across the application.REDIS_CLIENTtoken.getLeaderboard()with a 60-second expiration.any[]to avoid unsafeanywarnings.LeaderboardServiceis preserved without modifications to other providers.Changes
Redisclient intoLeaderboardServiceconstructor.getLeaderboard()to:RedisandREDIS_CLIENT.How to Test
.envwithREDIS_URL.Notes
LeaderboardService; other services remain unaffected.RedisModule.any[]due to lack of a dedicated DTO.