Refactor: Clean Architecture for IQ Assessment Module (#108)#117
Merged
phertyameen merged 1 commit intoMindBlockLabs:mainfrom Jul 29, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR refactors the IQAssessment module to follow NestJS clean architecture principles and resolve issue #108.
✨ Highlights:
Extracted individual responsibilities into isolated providers for better testability and maintainability.
Refactored IqAssessmentService to be an orchestrator using:
SubmitPuzzleProvider
VerifySolutionProvider
UpdateProgressProvider
CalculateRewardsProvider
UpdateUserStatsProvider
GetPuzzleProvider
GetPuzzlesProvider
Updated IqAssessmentModule to register all new providers.
Cleaned up IqAssessmentController to remove redundant injections and align with refactored service methods.
✅ Acceptance Criteria:
Service logic separated by responsibility
Controller properly updated
No changes to external API surface
Ready for unit test coverage improvements
Closes #108