Merged
Conversation
|
@nafiuishaaq Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the advanced middleware package in the middleware workspace for both timeout protection and circuit breaking. The timeout middleware/module is in timeout.middleware.ts (line 1), and the breaker state machine, middleware, and registration module are in circuit-breaker.middleware.ts (line 1). The breaker now supports configurable failure threshold, rolling failure window, half-open retry interval, CLOSED -> OPEN -> HALF_OPEN transitions, and exposes state via getState() / getSnapshot() on CircuitBreakerService.
I also exported the new advanced middleware surface through middleware/src/index.ts (line 1) and added state-machine coverage in circuit-breaker.middleware.spec.ts (line 1) plus timeout behavior checks in timeout.middleware.spec.ts (line 1). Those tests cover:
timed-out requests producing 503
circuit opening after the configured number of failures
OPEN -> HALF_OPEN
HALF_OPEN -> CLOSED on success
HALF_OPEN -> OPEN on failure
CLoses #355