ALFMOB-83: Wishlist Functionality(Continued)

[artyomromanov]

What is here

• Add Database for wishlist IDs,
• Flows to get and set them for PLP
• Grid and Large Item views
• UseCase to fetch the Wishlist products in Wishlist Screen itself(now simplified)

Demo

Screen_recording_20260119_134311.webm

TODO

• Unit Tests

[amccall-mindera]

Code Review — ALFMOB-83: Wishlist Functionality (Continued)

🔴 High — Silent error swallowing in GetWishlistUseCase

GetWishlistUseCase.kt:28-36 — When productRepository.getProduct(id) fails, the error is silently swallowed. The product becomes null and gets filtered out by filterNotNull(). If the network is down, the entire wishlist appears empty with no error indication.

async(Dispatchers.IO) {
    var product: Product? = null
    productRepository.getProduct(id)
        .onSuccess { product = it }
    product  // null if getProduct failed — silently dropped
}

Suggestion: Propagate errors to the UI, or at minimum log warnings and show partial-load indicators.

🔴 High — Error handling removed from WishlistViewModel

WishlistViewModel.kt:36-43 — The previous implementation had WishlistUiState.Error handling which was completely removed. Now results are always treated as success. If loading fails, the UI will either stay in Loading forever or show an incomplete wishlist.

Suggestion: Add error handling back. At minimum, wrap collectLatest in a try/catch and update state to an error variant.

🟠 Medium — Unused imports in AddToWishlistUseCase

AddToWishlistUseCase.kt:4-11 — Multiple unused imports left over from the old implementation (ProductRepository, Product, onSuccess, awaitAll, coroutineScope, Flow, flatMapLatest, flowOf). Will cause lint warnings.

🟡 Medium — Missing unit tests (noted as TODO)

The PR introduces GetWishlistIdsUseCase, rewrites GetWishlistUseCase (async parallel fetching), adds WishlistDao, and rewrites WishlistRepositoryImpl — all without tests. The existing GetWishlistUseCaseTest expects the old interface and will likely fail. The error handling gaps above make test coverage especially important.

Recommendation: The error handling issues (silent failure, removed error state) should be addressed before merge. Unit tests are also needed given the complexity of the async product-fetching logic.