Migrated Minds.com's engine to PHP v7.2.0.#31
Open
hopeseekr wants to merge 6 commits intoMinds:masterfrom
Open
Migrated Minds.com's engine to PHP v7.2.0.#31hopeseekr wants to merge 6 commits intoMinds:masterfrom
hopeseekr wants to merge 6 commits intoMinds:masterfrom
Conversation
PHP 7.2 made `object` a keyword, thus not allowing classes to be named as such.
Note: There is a bug in Email/Manager which this migration made visible.
The each() function will be removed in December with the release of PHP 7.3.
Prior to PHP 7.2.0, PHP merely ignored method signature discrepancies. But now, they are Fatal Errors, as they should be. Efforts at backward-compatibility were made, thus the `$unused` parameters.
So, the guys over at Twilio told me flat out that v3.13.1 of their SDK was very much EOL'd and they just wouldn't ever support PHP 7.2. They also told me that the first version to support PHP 7.2 was Twilio/SDK v6, which is a full three major versions ahead. Not knowing anything about this app's usage of Twilio, I resorted to forking Twilio and migrating v3.13.1 to PHP 7.2. By using my repo's 3.13.1-create-function-fix branch, all of the PHPSpec tests now pass!
hopeseekr
commented
Nov 27, 2018
| * Carousel Entity | ||
| */ | ||
| class Carousel extends Entities\Object | ||
| class Carousel extends Entities\MindsObject |
Author
There was a problem hiding this comment.
I went back and forth on whether to move all of the classes in the Object namespace to MindsObject as well, but in the interests of keeping changes to a minimum, I decided against doing so. Nothing seems to break by leaving it that way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: The Twilio/SDK v3.13.1 is incompatible with PHP v7.2 because it uses
create_functionin several places. Only their latest v6 supports PHP v7.2 and since v3 has been EOL'd, they definitely aren't going to backport PHP 7.2 fixes.So! Working with the Twilio devs, I backported the PHP 7.2 changes to v3.13.1 and updated this project's composer.json to use that specific project branch instead.
This change is