Add @exception variable for programmatic error inspection#1
Draft
Add @exception variable for programmatic error inspection#1
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: ryush00 <4997174+ryush00@users.noreply.github.com>
Co-authored-by: ryush00 <4997174+ryush00@users.noreply.github.com>
Co-authored-by: ryush00 <4997174+ryush00@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update error handling to store exception in variable
Add @exception variable for programmatic error inspection
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
@exceptioninstance variable that captures all exceptions regardless of@debugflag, enabling programmatic error inspection without stderr parsingDEFAULT_TIMEOUTinstead of undefinedtimeoutvariable, use@request_typeinstead of undefinedrequest_typevariable$!global variable with explicit exception parameters in all 19 rescue blocks per Ruby best practicesUsage:
Previously, errors were only visible via
$stderr.putswhendebug: true. Now exceptions are always accessible via theexceptionattribute, improving debuggability without requiring verbose stderr output.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
10.255.255.1require_relative 'lib/minestat'
Test different exception scenarios
puts 'Test 1: Connection refused (Errno::ECONNREFUSED)'
ms1 = MineStat.new('localhost', 1, timeout: 2, debug: false)
puts ' Exception class: ' + ms1.exception.class.to_s if ms1.except` (dns block)
Pass empty options hash to trigger the bug
ms = MineStat.new('test.example.com', 25565, {})
puts 'Finished'` (dns block)
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.