GEOPY-2450: Implement Maxwell plate model#837
Merged
domfournier merged 11 commits intodevelopfrom Feb 3, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #837 +/- ##
===========================================
+ Coverage 91.18% 91.21% +0.02%
===========================================
Files 113 114 +1
Lines 10067 10155 +88
Branches 1876 1887 +11
===========================================
+ Hits 9180 9263 +83
- Misses 474 475 +1
- Partials 413 417 +4
🚀 New features to boost your workflow:
|
MatthieuCMira
requested changes
Feb 2, 2026
Contributor
MatthieuCMira
left a comment
There was a problem hiding this comment.
Mostly docstring and typing.
Maybe uni-tests can be augment to test methods separately
Contributor
MatthieuCMira
left a comment
There was a problem hiding this comment.
A test failed.
Seems a naming random failure no?
domfournier
commented
Feb 3, 2026
Contributor
Author
domfournier
left a comment
There was a problem hiding this comment.
Maybe we need to chat about this.
Contributor
Author
To be addressed on GEOPY-2700 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2450 - Implement Maxwell plate model