Skip to content

GEOPY-2450: Implement Maxwell plate model#837

Merged
domfournier merged 11 commits intodevelopfrom
GEOPY-2450
Feb 3, 2026
Merged

GEOPY-2450: Implement Maxwell plate model#837
domfournier merged 11 commits intodevelopfrom
GEOPY-2450

Conversation

@domfournier
Copy link
Contributor

@domfournier domfournier commented Jan 30, 2026

GEOPY-2450 - Implement Maxwell plate model

@github-actions github-actions bot changed the title GEOPY-2450 GEOPY-2450: Implement Maxwell plate model Jan 30, 2026
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 92.23301% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.21%. Comparing base (4ba1b79) to head (5f2dc6c).
⚠️ Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
geoh5py/objects/maxwell_plate.py 93.02% 1 Missing and 5 partials ⚠️
geoh5py/objects/object_base.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #837      +/-   ##
===========================================
+ Coverage    91.18%   91.21%   +0.02%     
===========================================
  Files          113      114       +1     
  Lines        10067    10155      +88     
  Branches      1876     1887      +11     
===========================================
+ Hits          9180     9263      +83     
- Misses         474      475       +1     
- Partials       413      417       +4     
Files with missing lines Coverage Δ
geoh5py/data/visual_parameters.py 86.84% <100.00%> (+3.50%) ⬆️
geoh5py/objects/__init__.py 100.00% <100.00%> (ø)
geoh5py/objects/object_base.py 93.06% <66.66%> (-0.67%) ⬇️
geoh5py/objects/maxwell_plate.py 93.02% <93.02%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@MatthieuCMira MatthieuCMira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly docstring and typing.

Maybe uni-tests can be augment to test methods separately

Copy link
Contributor

@MatthieuCMira MatthieuCMira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test failed.
Seems a naming random failure no?

Copy link
Contributor Author

@domfournier domfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to chat about this.

@domfournier
Copy link
Contributor Author

A test failed. Seems a naming random failure no?

A test failed. Seems a naming random failure no?

To be addressed on GEOPY-2700

Copy link
Contributor

@MatthieuCMira MatthieuCMira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good for me

@domfournier domfournier merged commit deb968c into develop Feb 3, 2026
16 of 17 checks passed
@domfournier domfournier deleted the GEOPY-2450 branch February 3, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants