Skip to content

GEOPY-2697: Implement Airborne Apparent Conductivity survey type#838

Merged
domfournier merged 7 commits intodevelopfrom
GEOPY-2697
Feb 4, 2026
Merged

GEOPY-2697: Implement Airborne Apparent Conductivity survey type#838
domfournier merged 7 commits intodevelopfrom
GEOPY-2697

Conversation

@domfournier
Copy link
Contributor

@domfournier domfournier commented Feb 2, 2026

GEOPY-2697 - Implement Airborne Apparent Conductivity survey type

@github-actions github-actions bot changed the title GEOPY-2697 GEOPY-2697: Implement Airborne Apparent Conductivity survey type Feb 2, 2026
@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.20%. Comparing base (deb968c) to head (5bde603).
⚠️ Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
...jects/surveys/electromagnetics/airborne_app_con.py 89.88% 5 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #838      +/-   ##
===========================================
- Coverage    91.21%   91.20%   -0.02%     
===========================================
  Files          114      115       +1     
  Lines        10155    10243      +88     
  Branches      1887     1897      +10     
===========================================
+ Hits          9263     9342      +79     
- Misses         475      480       +5     
- Partials       417      421       +4     
Files with missing lines Coverage Δ
geoh5py/objects/__init__.py 100.00% <100.00%> (ø)
geoh5py/objects/surveys/electromagnetics/tipper.py 89.88% <ø> (-0.23%) ⬇️
...jects/surveys/electromagnetics/airborne_app_con.py 89.88% <89.88%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@MatthieuCMira MatthieuCMira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's good

some pylint complaining

Some typing missing

As someone arriving on this class, the docstrings did not helped me a lot.
What about being more precise for them?

MatthieuCMira
MatthieuCMira previously approved these changes Feb 3, 2026
Copy link
Contributor

@MatthieuCMira MatthieuCMira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for me.

Just fix the issues in the test and pylint

@domfournier domfournier merged commit de97635 into develop Feb 4, 2026
16 of 17 checks passed
@domfournier domfournier deleted the GEOPY-2697 branch February 4, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants