Open
Conversation
willayton
requested review from
athongsamai,
awmirantis,
mlimardo1984,
smerkviladze and
yevchuk-kostiantyn
as code owners
Author
|
Hey @mlimardo1984 or @smerkviladze , could I get a review or some feedback on this pull request? |
Author
|
Hey @yevchuk-kostiantyn, @awmirantis, could I get a review or some feedback on this pull request? Asking you two as the most recent PR approvers in this repository, let me know if I need someone else. |
willayton
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#394 did this already, but it introduced bugs in
make rpmand was backed out in #436.Aside from removing EoL distros, that added support for almalinux 8 and 9.
I want an RPM compatible with RHEL8, at least someone else wants the same for RHEL9.
I've mostly copied #394, but fixed the bugs it introduced in
make rpm. The fixes were:fedora-39(for which there is no Dockerfile) tofedora-41(for which there is a Dockerfile).