review #3
Open
review #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liorsagy
reviewed
Aug 31, 2022
|
|
||
| if (!CMakeLists.includes("#local")) { | ||
| if (!CMakeLists.includes("#local")) { // What is this? Why does CMakeLists include #local? | ||
| // I'm guessing it's because you are lazy and you didn't use an `if` in the CMakeLists. |
Member
There was a problem hiding this comment.
Its because i want to know if i need to delete the things in cbuild
Member
Author
There was a problem hiding this comment.
Why would you ever need to delete them?
It's dumb.
Have two different build directories for roborio and local.
I suggest build/local and build/roborio
| "Build Local", | ||
| "vscode-miscar", | ||
| new vscode.ShellExecution( | ||
| // Unless you are a complete dumbass, you know this doesn't work on other OSs. |
Member
There was a problem hiding this comment.
I will think about other solution for os
| const deploy = async (context: vscode.ExtensionContext) => { | ||
| // I'm not checking this. | ||
| // It's way to similar to the fast deploy. | ||
| // You gotta extract the shared code into a function |
| ] | ||
| let connects: any[] = [] | ||
| adresses.map((adress) => { | ||
| adresses.map((adress) => { // Address is pronounced with a double d |
| "172.22.11.2", | ||
| "roborio-1574-frc.local", | ||
| "roborio-1574-frc.local", // Try to generalize the team number. | ||
| // Learn about VSCode extension preferences, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.