Conversation
… old PRs Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix workflow to create PR only for tag_types.py changes
Fix sync-tag-definitions workflow: scope commits to tag_types.py only, close superseded PRs
Feb 11, 2026
Misiu
added a commit
that referenced
this pull request
Feb 11, 2026
* Initial plan * Fix tag type definition URL and improve error handling Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com> * Update fallback tag type definitions with complete data from OpenEPaperLink Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com> * Remove unnecessary bpp and rotatebuffer fields from fallback definitions Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com> * Add workflow to sync tag type definitions weekly from OpenEPaperLink Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com> * test Updated dimensions for BWRY example display. * Initial plan * Extract inline Python from workflow into scripts with tests and fix bugs - Move inline Python from sync-tag-definitions.yml into scripts/fetch_tag_types.py and scripts/generate_tag_types.py for easier debugging and change tracking - Fix re.sub() crash on Unicode escape sequences (e.g. \u2010) by using string slicing instead of regex replacement - Fix string vs integer key type mismatch when comparing JSON data - Fix lexicographic sorting of type IDs - Use ensure_ascii=False to preserve Unicode characters in output - Add 28 tests covering all script functions Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com> * Address code review: fix list comprehension safety and tighten unicode assertion Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com> * Fix test_overlapping_elements: regenerate reference image as JPEG The reference image overlapping_elements.png was saved as a real PNG while the image generator produces JPEG output. All other reference images are JPEG data (with .png extension). This mismatch caused the pixel-exact comparison to fail. Regenerated the reference from the current image generator output. Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com> * Rename JPEG test reference images from .png to .jpg All 52 test reference images contain JPEG data (confirmed by FFD8FF magic bytes) but had incorrect .png extensions. The image generator (core.py:411) explicitly outputs JPEG format. - Rename all 52 reference images from .png to .jpg - Update all 15 test files to reference .jpg instead of .png - Verified all 82 tests pass Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com> * Initial plan * Fix sync-tag-definitions workflow: only commit tag_types.py and close old PRs Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com> * Initial plan * Revert non-test changes to match upstream state Reverted config_flow.py, tag_types.py to upstream state, and removed sync-tag-definitions workflow, scripts/, and tests/scripts/ so this branch contains only test-related changes (png→jpg rename and overlapping_elements fix). This isolates the test fixes for a clean PR to the upstream repo. Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sync-tag-definitionsworkflow was committing the intermediatenew_tag_types.jsonfile alongsidetag_types.pyin automated PRs (see PR #6). It also had no mechanism to close stale PRs when a newer sync runs.add-paths: custom_components/opendisplay/tag_types.pytopeter-evans/create-pull-requestso only the target file is included in the PRrm -f new_tag_types.jsonafter generation as a belt-and-suspenders measuregh pr list/closeon theautomated/sync-tag-definitionsbranch to close any existing open PR with a comment, matching Dependabot-style behavior💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.