Skip to content

Conversation

@amartinz
Copy link

@amartinz amartinz commented May 3, 2016

  • remove final from onCreate to allow overriding
  • as the library depends on calling onCreate, add a CallSuper annotation
    to tell the library user that super.onCreate has to be called

Change-Id: Iee55651b080c05c6d655666a3c449d4ea5691b51
Signed-off-by: Alexander Martinz eviscerationls@gmail.com

amartinz added 2 commits May 3, 2016 16:30
 * remove final from onCreate to allow overriding
 * as the library depends on calling onCreate, add a CallSuper annotation
   to tell the library user that super.onCreate has to be called

Change-Id: Iee55651b080c05c6d655666a3c449d4ea5691b51
Signed-off-by: Alexander Martinz <eviscerationls@gmail.com>
Change-Id: I6d1490abb5e7dfcc15f58f97f0cb17f8b61aad0a
Signed-off-by: Alexander Martinz <eviscerationls@gmail.com>
@MizzleDK
Copy link
Owner

Thanks for all your pull requests! I'm sorry I haven't seen them before now. Will take a look at them within the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants