UT for commandCopyBuffer, commandCopyBufferRect, commandBarrierWithWa…#18
Open
kamil-goras-mobica wants to merge 2 commits intomainfrom
Open
UT for commandCopyBuffer, commandCopyBufferRect, commandBarrierWithWa…#18kamil-goras-mobica wants to merge 2 commits intomainfrom
kamil-goras-mobica wants to merge 2 commits intomainfrom
Conversation
shajder
requested changes
Oct 11, 2023
Comment on lines
3623
to
3624
| std::vector<cl_sync_point_khr> sync_points_vec { 0, 1, 2 }; | ||
|
|
Collaborator
There was a problem hiding this comment.
Good to see vector of sync points to hold execution of this call as long as other commands of out-of-order command buffer will be completed! Still we could do a bit better and get a sync point for at lease one call (fifth parameter) and verify if is as expected after actual call.
The same comment applies for below test testCommandCopyBufferRectKHR. Except this two corrections PR LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UTs for
commandCopyBuffer
commandCopyBufferRect
commandBarrierWithWaitList