Uts for commandFillBuffer, commandFillImage#19
Open
kamil-goras-mobica wants to merge 4 commits intomainfrom
Open
Uts for commandFillBuffer, commandFillImage#19kamil-goras-mobica wants to merge 4 commits intomainfrom
kamil-goras-mobica wants to merge 4 commits intomainfrom
Conversation
Collaborator
|
@kamil-goras-mobica recap of our discussion over this PR, conclusion is to split this PR into 6 smaller: |
kamil-goras-mobica
force-pushed
the
ut_commandfillbuffer
branch
from
2f927d4 to
3e1b7f7
Compare
kamil-goras-mobica
changed the title
shajder
requested changes
Oct 13, 2023
tests/test_openclhpp.cpp
Outdated
| #endif | ||
| } | ||
|
|
||
| cl_int clCommandFillBufferKHR_testcommandFillBuffer(cl_command_buffer_khr command_buffer, cl_command_queue command_queue, cl_mem buffer, |
Collaborator
There was a problem hiding this comment.
let's make that one static please
tests/test_openclhpp.cpp
Outdated
| TEST_ASSERT_EQUAL(*sync_point_wait_list, 0); | ||
| TEST_ASSERT_EQUAL_PTR(mutable_handle, nullptr); | ||
| TEST_ASSERT_NOT_EQUAL(sync_point, nullptr); | ||
| return 0; |
Collaborator
There was a problem hiding this comment.
We could return CL_SUCCESS explicitly
tests/test_openclhpp.cpp
Outdated
| cl_int ret = CL_INVALID_CONTEXT; | ||
| float pattern = 0; | ||
| size_t offset = 0; | ||
| size_t size = sizeof(pattern); |
Collaborator
There was a problem hiding this comment.
This should be size of the buffer to fill with the pattern, not the size of the pattern.
tests/test_openclhpp.cpp
Outdated
| const void* pattern, size_t pattern_size, size_t offset, size_t size, cl_uint num_sync_points_in_wait_list, | ||
| const cl_sync_point_khr* sync_point_wait_list, cl_sync_point_khr* sync_point, cl_mutable_command_khr* mutable_handle, int num_calls) | ||
| { | ||
| (void)size; |
Collaborator
There was a problem hiding this comment.
Preference to set and verify real value different then size of pattern.
Collaborator
Author
There was a problem hiding this comment.
@shajder Added corrections to all comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.