Open
Conversation
kamil-goras-mobica
changed the title
shajder
requested changes
Oct 16, 2023
tests/test_openclhpp.cpp
Outdated
Comment on lines
3654
to
3656
| cl::Kernel kernel; | ||
| cl::NDRange offset; | ||
| cl::NDRange global; |
Collaborator
There was a problem hiding this comment.
Preference to use real data eg. kernel from kernelPool.
| cl::NDRange global; | ||
| cl::NDRange local = cl::NullRange; | ||
| std::vector<cl_sync_point_khr> sync_points_vec{ 3,2,1 }; | ||
| cl_sync_point_khr sync_point{ 2 }; |
Collaborator
There was a problem hiding this comment.
At least one call could verify returned sync_point
kamil-goras-mobica
force-pushed
the
ut_CommandNDRangeKernel
branch
from
fce9f80 to
d01722b
Compare
shajder
requested changes
Oct 17, 2023
tests/test_openclhpp.cpp
Outdated
| @@ -3652,8 +3661,8 @@ void testCommandNDRangeKernel(void) | |||
| #if defined(cl_khr_command_buffer) | |||
| cl::vector<cl_ndrange_kernel_command_properties_khr> properties{ 0,1,2 }; | |||
| cl::Kernel kernel; | |||
Collaborator
There was a problem hiding this comment.
Preference to remove unused variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.