UTs for commandCopyImageToBuffer, commandCopyImage, commandCopyBufferToImage#24
Open
kamil-goras-mobica wants to merge 4 commits intomainfrom
Open
UTs for commandCopyImageToBuffer, commandCopyImage, commandCopyBufferToImage#24kamil-goras-mobica wants to merge 4 commits intomainfrom
kamil-goras-mobica wants to merge 4 commits intomainfrom
Conversation
shajder
requested changes
Oct 13, 2023
Collaborator
shajder
left a comment
shajder
left a comment
There was a problem hiding this comment.
My remarks applies for all tests, please review all.
tests/test_openclhpp.cpp
Outdated
Comment on lines
3643
to
3644
| cl::MutableCommandKhr* mutable_handle = nullptr; | ||
| const cl::CommandQueue* command_queue = nullptr; |
Collaborator
There was a problem hiding this comment.
minor, preference to save some space and pass nullptr's without additional variables.
tests/test_openclhpp.cpp
Outdated
Comment on lines
3647
to
3648
| ret = commandBufferKhrPool[0].commandCopyImageToBuffer(image2DPool[0], bufferPool[0], origin, region, dst_offset, &sync_points_vec, | ||
| &sync_point, mutable_handle, command_queue); |
Collaborator
There was a problem hiding this comment.
we could verify sync_point value set in clcommandCopyImageToBufferKHR_testcommandCopyImageToBuffer after this call.
tests/test_openclhpp.cpp
Outdated
Comment on lines
3641
to
3642
| cl_sync_point_khr sync_point = 0; | ||
| const cl::vector<cl_sync_point_khr> sync_points_vec = {sync_point}; |
Collaborator
There was a problem hiding this comment.
This will work but the code is a bit misleading. Sync points from wait list should not be the same as one returned by clCommandCopyImageToBuffer. Preference to use different values and avoid putting sync_point to the wait list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UTs for commandCopyImageToBuffer, commandCopyImage, commandCopyBufferToImage