Open
Conversation
piotr-wozniak-mobica
force-pushed
the
ut_compile
branch
from
53e2333 to
3461e8d
Compare
shajder
requested changes
Sep 29, 2023
tests/test_openclhpp.cpp
Outdated
Comment on lines
4564
to
4565
| clGetDeviceInfo_StubWithCallback(clGetDeviceInfo_platform); | ||
| clGetDeviceInfo_StubWithCallback(clGetDeviceInfo_platform); |
Collaborator
There was a problem hiding this comment.
Do we need two identical calls here ?
| clGetDeviceInfo_StubWithCallback(clGetDeviceInfo_platform); | ||
| clGetDeviceInfo_StubWithCallback(clGetDeviceInfo_platform); | ||
| clCompileProgram_StubWithCallback(clCompileProgram_testcompile); | ||
| clGetPlatformInfo_StubWithCallback(clGetPlatformInfo_version_1_1); |
Collaborator
There was a problem hiding this comment.
This is minor but can we put below two calls next to each other separated to other _StubWithCallbacks calls :
clGetDeviceInfo_StubWithCallback(clGetDeviceInfo_platform);
clGetPlatformInfo_StubWithCallback(clGetPlatformInfo_version_1_1);
Collaborator
There was a problem hiding this comment.
@shajder Added corrections, please take a look
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.