Open
Conversation
Collaborator
|
@piotr-wozniak-mobica as I mentioned during daily meeting, I would extend that unit test with |
shajder
requested changes
Aug 14, 2023
piotr-wozniak-mobica
force-pushed
the
ut_enqueueWriteImage
branch
from
10cf595 to
71b4561
Compare
Collaborator
|
@piotr-wozniak-mobica please resolve conflicts, I will have few more remarks here. |
piotr-wozniak-mobica
force-pushed
the
ut_enqueueWriteImage
branch
from
71b4561 to
1808d88
Compare
piotr-wozniak-mobica
force-pushed
the
ut_enqueueWriteImage
branch
from
1808d88 to
1d8405b
Compare
shajder
approved these changes
Sep 29, 2023
Collaborator
shajder
left a comment
shajder
left a comment
There was a problem hiding this comment.
except minor issues LGTM
tests/test_openclhpp.cpp
Outdated
| TEST_ASSERT_EQUAL(type, CL_GL_OBJECT_BUFFER); | ||
| TEST_ASSERT_EQUAL(bufobj, 0); | ||
| } | ||
| cl_int clEnqueueWriteImage_testenqueueWriteImage( |
Collaborator
There was a problem hiding this comment.
Can we make all local procedures static ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.