Skip to content

Multisample rasterization test - Testing purposes#8

Open
Mateusz-Kowalewski-Mobica wants to merge 61 commits intomainfrom
multisample_rasterization_test
Open

Multisample rasterization test - Testing purposes#8
Mateusz-Kowalewski-Mobica wants to merge 61 commits intomainfrom
multisample_rasterization_test

Conversation

@Mateusz-Kowalewski-Mobica
Copy link
Collaborator

@Mateusz-Kowalewski-Mobica Mateusz-Kowalewski-Mobica commented Nov 22, 2024

Description

Please include a summary of the change, new sample or fixed issue. Please also include relevant motivation and context.
Please read the contribution guidelines

Fixes #

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

pawel-jastrzebski-mobica and others added 30 commits October 13, 2023 13:58
@pawel-jastrzebski-mobica
Add initial test framework.
a930066 
Signed-off-by: Pawel Jastrzebski <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Add MSAAm sample code.
f36f9e6 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Add sample with SpaceModule scene.
3c4b9fe 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Rendering proper BaseModule scene.
e26d3da 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Fix copyrights.
0175f6a 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
First version of MSAA works.
0d06897 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Implement dynamic sample selection.
1170d1b 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Add setter for last_requested_extension_feature.
46258c2 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Fix clang-format.
447a3ad 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Merge branch 'KhronosGroup:main' into dynamic_state3_multisample_rast…
22c1930 
…erization
@pawel-jastrzebski-mobica
Fix copyright.
7e5319f 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Fix vulkan version.
4072330 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Update readme.
5e73402 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Remove unneeded code from shader.
0f88145 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Fix copyright.
2eed170 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Add README.md
032ca90 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Add sample to CMake.
6b3e879 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Remove explicit reference from local viewport initializer.
2e86179 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Change resources create/update logic.
37d42ce 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Fix clang-format.
82be0a3 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Fix format for vertex input attribute descriptor.
ccc694c 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Separate rendering for scene meshes with different rasterizer settings.
c7b872f 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Change camera position.
5d04e70 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Fix light position.
792fc0a 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Update README files.
94db8df 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Update sample image.
a805676 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Merge branch 'KhronosGroup:main' into dynamic_state3_multisample_rast…
d812e3e 
…erization
@pawel-jastrzebski-mobica
Fix warnings.
d537ce4 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Fix typos in README files.
143196d 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Fix comment.
e5fb84c 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Fix review comments.
1bc20d4 
Changes made:
- Fix errors in README
- Remove mandatory setting for Vulkan 1.1
- Add additional checks and asserts
- Replace loop with algorithms
- Remove unnecessary code and conditions
- Reorganise rendering of opaque and transparent meshes
- Change filename and class name of the sample

Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Fix review comments.
59686d3 
Changes made:
- Fix misleading description in README
- Change textures handling in rendering

Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Merge branch 'main' into dynamic_state3_multisample_rasterization
e6f1413
@pawel-jastrzebski-mobica
Rename project.
e6829cd 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Fix review comments.
92f0bbf 
Issues solved:
- remove unneeded code
- fix vulkan validation errors

Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Add multisampling to GUI rendering.
f037dc3 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Update README
d2016f3 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Change rotation speed.
ca0a459 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Fix clang-format.
f4d0e0e 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Update copyright year.
9ca4309 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@Mateusz-Kowalewski-Mobica
Copyright fix in CMakeLists
8d4c1d1
@pawel-jastrzebski-mobica
Fix review comments.
7e1e986 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@pawel-jastrzebski-mobica
Fix review comments.
b2421ad 
Signed-off-by: pawel-jastrzebski-mobica <pawel.jastrzebski@mobica.com>
@Mateusz-Kowalewski-Mobica
Fix VUID-VkSubpassDescription-pResolveAttachments-00848
0b806c6
@Mateusz-Kowalewski-Mobica
Image destroy refactor
7e2434b
@Mateusz-Kowalewski-Mobica
Fix windows build issue
c4d78cb
@Mateusz-Kowalewski-Mobica
Add dynamic rendering
ff3708b
@Mateusz-Kowalewski-Mobica
Gui merge conflicts fix
6f73a24
@Mateusz-Kowalewski-Mobica
Fix regressions after implementing dynamic rendering
65b93cd
@Mateusz-Kowalewski-Mobica
Merge branch 'main' into dynamic_state3_multisample_rasterization
7af25fd
@Mateusz-Kowalewski-Mobica
Adjust sample to changes from PR#910
bdb6973
@Mateusz-Kowalewski-Mobica
Fix sync issue
38fb8bd
@Mateusz-Kowalewski-Mobica
Documentation update
130d3e4
@Mateusz-Kowalewski-Mobica
Merge branch 'main' into dynamic_state3_multisample_rasterization
8aacbb8
@Mateusz-Kowalewski-Mobica
Merge branch 'main' into dynamic_state3_multisample_rasterization
5467a77
@Mateusz-Kowalewski-Mobica
Remove unused feature
7acbd64
@Mateusz-Kowalewski-Mobica
VK objects initializations added
22b56ac
@Mateusz-Kowalewski-Mobica
Merge branch 'main' into multisample_rasterization_test
5bad749
@Mateusz-Kowalewski-Mobica
Merge branch 'main' into multisample_rasterization_test
baf0203
@Mateusz-Kowalewski-Mobica
Fixing framework calls after merge
f7f843f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mateusz-Kowalewski-Mobica @pawel-jastrzebski-mobica