Open
Conversation
…up#1392) * Fix use of --width and --height by setting extent earlier dynamic_rendering_local_read (at least) would go horribly wrong if --width and --height were given on the command line. This change ensures the framework extent is set before it's used by the samples (in setup_render_pass() for DRLR). * Moved the setting further up in the function
* Added Slang shaders for dynamic rendering local read sample * Fix normal calculation for Slang shader * Enable extensions required when running with Slang shaders * Added HLSL shaders for dynamic rendering local read sample * Added SPIR-V files * Added Slang shaders for dynamic rendering sample * Update copyright headers * Trying to fix clang format Seems to have issues with code in defines * Add HLSL and Slang shaders for Vulkan 1.3 hello triangle samples * Update copyrights * Force column-major layout for Slang shader compilation * Add clamping to HLSL and Slang shader * Fix copyright
…hronosGroup#1405) * Update apple deployment targets to macOS 13.3 and iOS 16.3 * Update iOS Simulator build config and instructions for arm64 hosts * Update iOS Simulator build instructions to require SDK 1.4.321.0 or later
…core::PhysicalDevice<bindingType> (KhronosGroup#1404) * Unify vkb::PhysicalDevice and vkb::core::HPPPhysicalDevice into vkb::core::PhysicalDevice<bindingType> * Add HPPType<VkPhysicalDevicePortabilitySubsetFeaturesKHR>, guarded by VKB_ENABLE_PORTABILITY * Fix assert in constructor of VulkanStatsProvider.
…b::rendering::RenderContext<bindingType> (KhronosGroup#1410)
…ad_control features." This reverts commit d9524ac.
* Add simple_tensor_and_data_graph sample * Added initial tensor and data graph sample, common framework and documentation. Signed-off-by: Aron Virginas-Tar <aron.virginas-tar@arm.com> * Address 1st round of PR comments * Fixed issues highlighted by reviewers * Fixed copyright headers Signed-off-by: Aron Virginas-Tar <aron.virginas-tar@arm.com> * Fix copyright headers and formatting Signed-off-by: Aron Virginas-Tar <aron.virginas-tar@arm.com> * Fix build after merging new PhysicalDevice API Signed-off-by: Aron Virginas-Tar <aron.virginas-tar@arm.com> * Disable building the sample on unsupported platforms Signed-off-by: Aron Virginas-Tar <aron.virginas-tar@arm.com> * Reformatted with clang-format-15 Signed-off-by: Aron Virginas-Tar <aron.virginas-tar@arm.com> * Documentation improvements Signed-off-by: Aron Virginas-Tar <aron.virginas-tar@arm.com> * Address .adoc link issues Signed-off-by: Aron Virginas-Tar <aron.virginas-tar@arm.com> * Update simple_tensor_and_data_graph sample to latest main Signed-off-by: Matthew Sloyan <matthew.sloyan@arm.com> * Fix clang-format issues and add Int64 check Signed-off-by: Matthew Sloyan <matthew.sloyan@arm.com> --------- Signed-off-by: Aron Virginas-Tar <aron.virginas-tar@arm.com> Signed-off-by: Matthew Sloyan <matthew.sloyan@arm.com> Co-authored-by: Matthew Sloyan <70519899+matthewsloyanARM@users.noreply.github.com> Co-authored-by: Matthew Sloyan <matthew.sloyan@arm.com>
…ple dynamic_rendering_local_read (KhronosGroup#1424)
KhronosGroup#1413) * unify_Node * Fix dynamic_cast to reinterpret_cast in Node<bindingType>::get_parent() + two minor improvements
* Sample for fragment density map * Fix rebase conflicts * Add shaders spirv * fix format issues in CLI * PR improvements
…sGroup#1417) * Add the ability to specify a custom alignment when creating a buffer. - Use the correct alignment for scratch buffers and SBT's. * Update ray_queries, ray_tracing_reflection and mobile_nerf_rayquery samples to use the correct alignment. * Fix missing sType * Formatting fixes * Fix formatting in acceleration_structure.h * Change alignment member in buffer.h to be private.
…:core::Device constructor. (KhronosGroup#1428)
* Enabled SPIR-V 1.4 extension and use VK 1.1 if required This is needed to get proper support for SPIR-V compiled from Slang shaders * Add slang shaders for - instancing - conditional rendering - conservative rasterization * Add slang shaders for - dynamic uniform buffers - descriptor buffer basic - fragment shading rate * Add slang shaders for - hdr (+hpp) - graphics pipeline library - mesh shading (+hpp) * Fix copyright * Add slang shaders for - texture loading (+hpp) - push descriptors (+hpp - open cl interop * Fix copyright * Add slang shaders for - separte image sampler (+hpp) - texture mipmap generation (+hpp) - shader debug printf - texture compression basisu * Add slang shaders for - compute nbody (+hpp) * Add slang shaders for - dynamic primitive clipping - logic op dynamic state - sparse image * Add slang shaders for - color write enable - debug utils - dynamic line rasterization * Add slang shaders for - ray queries - ray tracing basics - ray tracing extended - ray tracing position fetch * Update reeadme for shaders * Add slang shaders for - terrain tessellation - patch control points - synchronization 2 - vertex dynamic state * Add slang shaders to hpp variant * Add slang shaders for - descriptor indexing * Add slang shaders for - dyamic blending * Add slang shaders for - time stamp queries (+hpp) - host image copy * Add slang shaders for - fragment shader barycentric - memory budget * Add slang shaders for - calibrated timestamps - dynamic multisample rasterization * Add slang shaders for - open gl interop * Add slang shaders for - portability * Fix copyright * Skip Slang offline compilation on MacOS/iOS when run through CI Slang compiler in current SDK is broken Not necessary anway as we ship offline compiled SPIR-V anyway, so unnecessary waste of CI time * Fix copyright * Add slang shaders for - gshader_to_mshader Still needs some lighting fixes * Fix lighting for gshader_to_mshader Calculate normal matrix on CPU * Add slang shaders for - extended dynamic state2 * Fix descriptor indexing not properly displaying right side of screen when using Slang * Add offline compiled SPIR-V files for slang shaders * Enalbe VK_KHR_Shader_Draw_Parameters when using Slang * Add slang shaders for - timeline semaphores * Add slang shaders for - buffer device address * Recompile Slang shader with updated compiler version * Fix ambient factor * Clamp specular contribution * Fix copyright * Enable device extensions required for proper Slang support * Enable feature required when using Slang * Add CMake option to disable Slang shader compilation * Add note on Slang compiler requirements * Fix normal calculation * Check if required feature is supported and if not exit gracefully * Address pull request feedback Match GLSL blur parameters * Address pull request feedback Ident using spaces * Address pull request feedback Remove unused input * Address pull request feedback Ident using spaces * Address pull request feedback Adjust light position to match GLSL * Address pull request feedback Cast to float3x3 * Address pull request feedback Remove unused normal input * Address pull request feedback Get size of blur parameters from array instead of hard-coding * Trying to fix clang format * Address pull request feedback Use point size related built-ins * Address pull request feedback Use getCount for const array size * Address pull request feedback * Address pull request feedback and cleanup * Address pull request feedback * Clean up existing shaders Remove attributes not required by Slang * Spaces instead of tabs * Address PR feedback
…lti_draw_indirect. (KhronosGroup#1444)
…ampler<bindingType> (KhronosGroup#1439)
* Set default queue priorities to 0.0f * Adjust queue priorities to 0.5f
…ronosGroup#1453) In the default constructor, textures.envmap.sampler is initialized to a non‑null garbage value (not VK_NULL_HANDLE). When timestamps aren’t supported, load_texture_cubemap() doesn’t overwrite it, so the destructor calls vkDestroySampler(...) with this invalid handle, causing a crash. Signed-off-by: Ryan Zhang <ryan.zhang@nxp.com> Co-authored-by: Ryan Zhang <ryan.zhang@nxp.com>
…onosGroup#1450) * Fix pMaxDeviation parameter type in calibrated_timestamps sample * Apply clang-format * comment revised
…s_merge # Conflicts: # samples/CMakeLists.txt
…ns sample - Use correct pipeline layouts when binding descriptor sets in DEBUG_SUBGROUPS_SWITCH_ENABLE mode - Create separate pipeline layouts for subgroups_off variants - Update shader loading to use pre-compiled .spv files - Add GLSLC target SPIR-V 1.4 compilation flag - Fix descriptor pool to include COMBINED_IMAGE_SAMPLER type - Update PhysicalDevice type to PhysicalDeviceC - Remove glsl_compiler.h include and GLSLCompiler setup (now handled by build system) - Mark destructor as override
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This has all of the fixes that I could do. Submitting as a PR here. Hopefully original authors can accept a PR and we can get this excellent sample merged.
Fixes #
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: