chore: refactor client package to use esm#33
Open
stephancill wants to merge 4 commits intoMobileWalletProtocol:masterfrom
Open
chore: refactor client package to use esm#33stephancill wants to merge 4 commits intoMobileWalletProtocol:masterfrom
stephancill wants to merge 4 commits intoMobileWalletProtocol:masterfrom
Conversation
stephancill
commented
Mar 13, 2025
Comment on lines
-1
to
+6
| import AsyncStorage from '@react-native-async-storage/async-storage'; | ||
| import AsyncStorage_, { AsyncStorageStatic } from '@react-native-async-storage/async-storage'; | ||
|
|
||
| import { KeyValueStorage, Scope, ScopedStorage } from './types'; | ||
| import { KeyValueStorage, Scope, ScopedStorage } from './types.js'; | ||
|
|
||
| // AsyncStorage type not correctly inferred by compiler so we have to cast it manually | ||
| const AsyncStorage = AsyncStorage_ as unknown as AsyncStorageStatic; |
Author
There was a problem hiding this comment.
This was the one weird issue I ran into when migrating. Seems like the type isn't being inferred correctly from the default export
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored
packages/clientto use ESM.Depends on #32
How did you test your changes?
yarn buildnpx @arethetypeswrong/cli --pack