don't generate extra impl for Eq assertions
#128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 10, 2025
…r, r=jieyouxu some `derive_more` refactors some clauses can be merged together without requiring an attribute for each trait derived. also manually impl `Eq` because the `derive_where` generated code is too much for my comfort (cc ModProg/derive-where#128)
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 10, 2025
…r, r=jieyouxu some `derive_more` refactors some clauses can be merged together without requiring an attribute for each trait derived. also manually impl `Eq` because the `derive_where` generated code is too much for my comfort (cc ModProg/derive-where#128)
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 10, 2025
…r, r=jieyouxu some `derive_more` refactors some clauses can be merged together without requiring an attribute for each trait derived. also manually impl `Eq` because the `derive_where` generated code is too much for my comfort (cc ModProg/derive-where#128)
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 10, 2025
…r, r=jieyouxu some `derive_more` refactors some clauses can be merged together without requiring an attribute for each trait derived. also manually impl `Eq` because the `derive_where` generated code is too much for my comfort (cc ModProg/derive-where#128)
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 10, 2025
…r, r=jieyouxu some `derive_more` refactors some clauses can be merged together without requiring an attribute for each trait derived. also manually impl `Eq` because the `derive_where` generated code is too much for my comfort (cc ModProg/derive-where#128)
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Aug 10, 2025
Rollup merge of #145145 - fee1-dead-contrib:push-qnmpmtmtpkkr, r=jieyouxu some `derive_more` refactors some clauses can be merged together without requiring an attribute for each trait derived. also manually impl `Eq` because the `derive_where` generated code is too much for my comfort (cc ModProg/derive-where#128)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eqalready has a methodassert_receiver_is_total_eqthat allows you to put asserts in. This PR makes it so we use that instead of generating a new trait and impl every time (which could be a lot).This is also a cleanup because apparently
additional_implis only used byEq(and arguably quite confusing asadditional_implis used to generate theEqimpl while the "main"implwas the extra impl) so we can remove that now.generating a
struct __AssertEqeach time is still a little wasteful, but given thatderive-whereis a single crate (so no "normal" support crate to share types) it might be unavoidable.