Skip to content

Save the configuration to a TOML configuration file #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CGodiksen merged 31 commits into from
Dec 11, 2025
Merged

Save the configuration to a TOML configuration file #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
238b796
Use local data folder when creating configuration manager
CGodiksen Dec 8, 2025
6cc6018
Add serde and toml to dependencies
CGodiksen Dec 8, 2025
38de80f
Add default for ClusterMode to handle serde deserialization
CGodiksen Dec 8, 2025
d4e369b
Add TOML deserialize error to ModelarDbServerError
CGodiksen Dec 8, 2025
b0f5a7e
Add TOML serializer error to ModelarDbServerError
CGodiksen Dec 8, 2025
26042b3
Try to retrieve config from file when creating configuration manager
CGodiksen Dec 8, 2025
b21e73e
Add validation method that checks that the configuration is valid
CGodiksen Dec 8, 2025
bc44af8
Fix doc error in configuration
CGodiksen Dec 8, 2025
e979fb1
Make it clear in the documentation that UpdateConfiguration updates t…
CGodiksen Dec 9, 2025
8cf2e76
Remove default from ClusterMode enum
CGodiksen Dec 9, 2025
262f250
Move the actual configuration to a separate type to make serializatio…
CGodiksen Dec 9, 2025
3fe68a6
Save the configuration when it is updated
CGodiksen Dec 9, 2025
b47dd8e
Use a consistent structure for the doc comments
CGodiksen Dec 9, 2025
b796580
Add test to ensure configuration file is created if it does not exist
CGodiksen Dec 9, 2025
85a59ae
Add test to ensure configuration file is read if it exists
CGodiksen Dec 9, 2025
6d11839
Add check to set_ tests to ensure the file is updated
CGodiksen Dec 9, 2025
2f31911
Fix doc minor issues
CGodiksen Dec 9, 2025
f6b79ae
Add test for ensure invalid configuration files are not accepted
CGodiksen Dec 9, 2025
3ff5e4f
Add test to ensure invalid TOML is not accepted
CGodiksen Dec 9, 2025
cd6125b
Simplify writing to file in test
CGodiksen Dec 9, 2025
1794fac
Change test naming for consistency
CGodiksen Dec 9, 2025
e2aa46f
Added a default implementation for Configuration struct
CGodiksen Dec 10, 2025
77924c4
Update documentation to make it clear env var takes precedence
CGodiksen Dec 10, 2025
a93f81c
Update the configuration from env if possible
CGodiksen Dec 10, 2025
9d50a81
Move save_configuration to Configuration struct
CGodiksen Dec 10, 2025
210095a
Move validate_configuration to Configuration struct
CGodiksen Dec 10, 2025
4f09973
Always update from env, validate, and save to toml
CGodiksen Dec 10, 2025
a03236c
Add error handling for when we parse environment variables
CGodiksen Dec 10, 2025
be10dd1
Change modelardb.toml to modelardbd.toml
CGodiksen Dec 11, 2025
5d9529a
Add method for getting the cluster mode instead of the field being pu…
CGodiksen Dec 11, 2025
c497092
Update based on comments from @skejserjensen
CGodiksen Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,14 @@ prost = "0.13.1"
prost-build = "0.13.1"
rand = "0.9.2"
rustyline = "17.0.2"
serde = { version = "1.0.228", features = ["derive"] }
snmalloc-rs = "0.3.8"
sqlparser = "0.58.0"
sysinfo = "0.37.2"
tempfile = "3.23.0"
tokio = "1.48.0"
tokio-stream = "0.1.17"
toml = "0.9.8"
tonic = "0.13.1"
tracing = "0.1.41"
tracing-subscriber = "0.3.20"
Expand Down
2 changes: 2 additions & 0 deletions crates/modelardb_server/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,11 @@ modelardb_storage = { path = "../modelardb_storage" }
modelardb_types = { path = "../modelardb_types" }
object_store = { workspace = true, features = ["aws", "azure"] }
prost.workspace = true
serde.workspace = true
snmalloc-rs = { workspace = true, features = ["build_cc"] }
tokio = { workspace = true, features = ["rt-multi-thread", "signal"] }
tokio-stream.workspace = true
toml.workspace = true
tonic.workspace = true
uuid.workspace = true

Expand Down
Loading