Remove coverage from RUSTFLAGS in build_and_upload_binaries#377
Merged
Remove coverage from RUSTFLAGS in build_and_upload_binaries#377
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the CI workflow to ensure release binaries uploaded from main are built without coverage instrumentation, while still enforcing warnings-as-errors and stripping symbols.
Changes:
- Override
RUSTFLAGSfor thebuild_and_upload_binariesjob to remove-C instrument-coverage. - Keep
-C strip=symbolsand-D warningsfor the release artifact build.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chrthomsen
approved these changes
Mar 16, 2026
skejserjensen
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the wheel files from the artifacts created in the "build_and_upload_binaries", a minor bug was found where a ".profraw" code coverage file was generated every time the Python code importing the Library was executed. We still want to generate the code coverage report for the other steps but for the built artifacts, this should not be necessary.