Move modelardb_embedded definitions to C header#378
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #373 by moving modelardb_embedded definitions to a C header. The C header is read in
operations.pysimilarly to how the library is read and the Python package build scripts have been updated to include the header file.The PR also includes some minor fixes to consistency issues between
capi.rsand the header file and a fix to a small bug found in the table Python tests.One thing to note is that we include the
ARROW_C_DATA_INTERFACEfrom https://arrow.apache.org/docs/format/CDataInterface.html directly in the header file. Based on the documentation it seems that the intention is to copy these definitions directly into your own projects code so this is what we do.