Remove Apache Arrow Flight tester for manager nodes#56
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the Apache Arrow Flight tester for manager nodes following the architecture simplification in PR #367. The codebase is restructured from a two-node-type system (manager and server) to a single server-only architecture.
- Removed manager-specific functionality (
manager.pyand associated protobuf definitions) - Refactored common code into dedicated modules:
wrapper.pyfor base Flight client operations andutil.pyfor testing utilities - Updated
server.pyto inherit from the newFlightClientWrapperbase class
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Removed documentation references to manager node testing |
| Apache-Arrow-Flight-Tester/wrapper.py | New base class providing common Apache Arrow Flight client wrapper methods |
| Apache-Arrow-Flight-Tester/util.py | New module containing testing utility functions previously in common.py |
| Apache-Arrow-Flight-Tester/server.py | Refactored to use FlightClientWrapper and util module; removed manager-specific code |
| Apache-Arrow-Flight-Tester/protobuf/protocol_pb2.pyi | Removed ManagerMetadata and NodeMetadata definitions |
| Apache-Arrow-Flight-Tester/protobuf/protocol_pb2.py | Updated generated protobuf code without manager/node metadata |
| Apache-Arrow-Flight-Tester/protobuf/protocol.proto | Removed ManagerMetadata and NodeMetadata message definitions |
| Apache-Arrow-Flight-Tester/manager.py | Deleted - no longer needed after architecture change |
| Apache-Arrow-Flight-Tester/common.py | Deleted - functionality split into wrapper.py and util.py |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
skejserjensen
approved these changes
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Apache Arrow Flight tester to match the architecture change made in ModelarData/ModelarDB-RS#367. Since we no longer have to test two different types of nodes, with some common functionality, the tester has also been restructured. Now we have a single class for the base Flight Server methods, one class for the server functionality, and a
util.pyfile for testing functionality.This PR should not be merged before ModelarData/ModelarDB-RS#367 is merged.