Draft
Conversation
halotroop2288
commented
Jul 10, 2025
halotroop2288
commented
- Groovy DSL -> Kotlin DSL
- Gradle Wrapper -> 8.14.2
- Gradle Version Catalog
- Lombok -> 1.18.38
- GSON -> 2.9.1
- Glass Site Java API -> 0.7
- GlassLauncher Commons -> 1.4
- Local blog -> Online updated blog
- Groovy DSL -> Kotlin DSL - Gradle Wrapper -> 8.14.2 - Gradle Version Catalog - Lombok -> 1.18.38 - GSON -> 2.9.1 - Glass Site Java API -> 0.7 - GlassLauncher Commons -> 1.4 - Local blog -> Online updated blog
calmilamsy
requested changes
Jul 10, 2025
Member
calmilamsy
left a comment
calmilamsy
left a comment
There was a problem hiding this comment.
Thanks for taking the time to update the gradle system and some of my more questionable code choices.
I do have concerns on loading remote content vs storing it locally just so the launcher keeps looking nice when there's no internet connection. Maybe keep the old system as an offline fallback/toggle?
Just doing a few formatting pokes so they don't spiral.
Comment on lines
+177
to
+185
| private JScrollPane makeBlog() { | ||
| JTextPane blog = new JTextPane(); | ||
| blog.setContentType("text/html"); | ||
| blog.setText(page); | ||
| try { | ||
| blog.setPage(new URL("https://halotroop2288.github.io/MCUpdate")); | ||
| blog.setContentType("text/html"); | ||
| } catch (Throwable ignored) { | ||
| Main.getLogger().warning("Couldn't load MCUpdate Blog."); | ||
| } | ||
|
|
Comment on lines
+17
to
+30
| switch (arg.toLowerCase()) { | ||
| case "-dosound": | ||
| doSound = true; | ||
| break; | ||
| case "-doskin": | ||
| doSkin = true; | ||
| break; | ||
| case "-docape": | ||
| doCape = true; | ||
| break; | ||
| case "-dologin": | ||
| doLogin = true; | ||
| break; | ||
| } |
Comment on lines
+58
to
+59
| return defaultColor != getForeground() && Arrays.equals(super.getPassword(), hint.toCharArray()) | ||
| ? new char[]{} : super.getPassword(); |
Comment on lines
+181
to
+189
| } else if (!version.equals("custom")) { | ||
| try { | ||
| FileUtils.delete(new File(minecraftFolder)); | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); | ||
| } | ||
| } | ||
|
|
||
| progressWindow.increaseProgress(); | ||
| progressWindow.increaseProgress(); |
Comment on lines
+252
to
+258
| if (component.getUid().equals("customjar") && !component.isDisabled()) { | ||
| hasCustomJar = true; | ||
| } else if (component.getCachedName() != null) { | ||
| modList.getJarMods().add(modList.getJarMods().size(), new Mod(component.getUid().replace("org.multimc.jarmod.", "") + ".jar", component.getCachedName(), 0, !component.isDisabled())); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.