Adjust leader rotation proof eligibility #12
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| leaderFinished := idx < epochHandler.CurrentLeaderIndex || | ||
| (idx == epochHandler.CurrentLeaderIndex && leaderTimeIsOut(epochHandler, networkParams, idx)) | ||
|
|
||
| if leaderFinished { |
There was a problem hiding this comment.
The finalization thread decides which leaders are ready to collect rotation proofs by comparing idx with epochHandler.CurrentLeaderIndex here, but the handler it uses comes from the EPOCH_HANDLER snapshot stored in EPOCH_DATA when an epoch is created (see threads/find_new_epoch.go where it is written once) and is never updated as the approvement thread advances the leader index. This means CurrentLeaderIndex remains at its initial value (often 0), so only the first leader is ever considered finished and allLeaderRotationProofsCollected never becomes true. In practice the ALRP collector will get stuck on the first leader of the first epoch and processingEpochId will never advance, so no aggregated leader rotation proofs are produced for subsequent leaders or epochs.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task