__PACKAGE__() as a sub, not a special token#129
Open
amiri wants to merge 1 commit intoMoeOrganization:masterfrom
Open
__PACKAGE__() as a sub, not a special token#129amiri wants to merge 1 commit intoMoeOrganization:masterfrom
amiri wants to merge 1 commit intoMoeOrganization:masterfrom
Conversation
Member
|
Hmm, are you sure it requires the parens? Perhaps making it a special token might not be a bad idea. |
Author
|
This current implementation requires parens, PACKAGE(). Otherwise the interpreter attempts to resolve it as a class. I will definitely work on making it a special token or adding a special keyword parser. |
Member
|
Excellent, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added PACKAGE as a sub, and I would like to check whether this is the right basic idea. It seems like to make it work as just PACKAGE, I need to make it something like selfLiteral in MoeLiterals or I need to provide some special keyword parser, like for subroutineCall in MoeProductions.