[201_90] fix inner product symbol display in tab cycle popup#2939
Open
1sh-repalto wants to merge 1 commit intoMoganLab:mainfrom
Open
[201_90] fix inner product symbol display in tab cycle popup#29391sh-repalto wants to merge 1 commit intoMoganLab:mainfrom
1sh-repalto wants to merge 1 commit intoMoganLab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2926
Inner product symbol does not show on Tab cycling popup window
Summary
When cycling through math variants for the
<key (which includes the inner product⟨⟩as the 7th variant), the popup window showed a broken/red symbol instead of the angle brackets.Developer Document:
devel/201_90.mdIssue Found
The
math-bracket-opencase inlambda-to-symbolwas concatenating the left and right bracket symbols (e.g.,"<langle><rangle>"). This produced a compound string that thewidget-boxrendering engine (using theromanfont) could not render correctly, showing as a red broken symbol or--.Changes
In
TeXmacs/progs/math/math-edit.scm:Modified
lambda-to-symbolto return only the left bracket symbol formath-bracket-open:((math-bracket-open) (and (>= (length (cdr body)) 2) (string? (cadr body)) (string? (caddr body)) (let ((lb (cadr body)) (rb (caddr body))) `(symbol-completion - ,(string-append lb rb))))) + ,lb))))How to test
$<Tabrepeatedly (7 times) to reach the inner product⟨⟩variant⟨clearly (instead of a broken red symbol or--)Tabonce more to return to<and verify the cycle continues correctly