Added empty dictionary for ComputeError extras default instead of None#301
Open
coltonbh wants to merge 1 commit intoMolSSI:masterfrom
Open
Added empty dictionary for ComputeError extras default instead of None#301coltonbh wants to merge 1 commit intoMolSSI:masterfrom
coltonbh wants to merge 1 commit intoMolSSI:masterfrom
Conversation
Collaborator
Author
|
I think something might be funny with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As per previous discussion about
native_fileswhen we have empty fields that aredictobjects we want their default value to be{}notNone.{}evaluates falsey in python so it can still be treated as a "null object" and we remove needing to check the case ofNonefor.extras. This makes coding easier because we can always do:Instead of having to always check this first:
Changelog description
Change default value for
ComputeError.extrafromNoneto{}Status