Conversation
59e7884 to
8f2d8b5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files |
e28d0ca to
cf87140
Compare
aa014ef to
5ceedc3
Compare
5ceedc3 to
d515a5f
Compare
Collaborator
Author
|
Requesting review @davidbrownell, @krachwal, @rfievet, @ketanbj, @varun646, @jyoung3131 |
krachwal
approved these changes
Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
qcelemental.models.v2. It is not accessed by default.models.v1intomodels, applying themodelsportion of @Lnaden 's Pydantic v2 Overhaul [DNM yet] #321, and copying the result down tomodels.v2. Only the 4th commit d515a5f is changes to make it all work.Changelog description
Status