Skip to content

Reimplement build system#3

Open
alexmaryewski wants to merge 38 commits intoMolecolab-Pisa:masterfrom
alexmaryewski:cmake_fix
Open

Reimplement build system#3
alexmaryewski wants to merge 38 commits intoMolecolab-Pisa:masterfrom
alexmaryewski:cmake_fix

Conversation

@alexmaryewski
Copy link

This PR intends to solve the long-standing issue of CMake structure in the project.

Main changes are:

  • Building reimplemented from scratch using modern CMake guidelines; solves multiple problems, e.g. parallel compilation bugs and such.
  • Project configuration through config.cmake is now supported.
  • Toolchain files are now supported; so far I only added GNU and Intel.
  • Building and installing Python interface is now an additional option; no separate configuration & build required.
  • Project install is now properly detected; dependencies are handled correctly.
  • Various test fixes.

Some of the CMake parts (BuildUtils.cmake and toolchains) are adapted from DFTB+. I'm currently awaiting a response from the developers concerning licensing, but it's not supposed to be a very big issue, since they are also on LGPL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants