Quests, Ambush Refactor & Human NPC overhaul by dwasint · Pull Request #5357 · Monkestation/Vanderlin

dwasint · 2026-02-22T10:24:10Z

About The Pull Request

This is like total difficulty spike across the board since human AI is DRASTICALLY more "resourceful"
ports: Azure-Peak/Azure-Peak#4206 & Azure-Peak/Azure-Peak#3507
with cleanup done around points I found weird.

New Human AI (still wip)

Why It's Good For The Game

Changelog

🆑
add: human npcs are more dynamic in their interaction
add: threat system to areas to scale ambush intensity, decreases as ambushes are spawned so FG can work
add: questing system
/:cl:

Pre-Merge Checklist

You tested this on a local server.
This code did not runtime during testing.
You documented all of your changes.

…ings based on an item attack, adds in craftable automatons

…y mod

… limbs actually robotic with a bullshit fix to get them to render

…r behaviors that are deemed complmentary. npcs can feint and use stamina I'm low key evil.

code/game/objects/items/weapons/rmb_intents.dm

CheffieGithub · 2026-02-26T21:24:45Z

code/controllers/subsystem/regional_threat.dm

+	return ..()
+
+/datum/controller/subsystem/regionthreat/fire(resumed)
+	var/player_count = GLOB.player_list.len


Suggested change

var/player_count = GLOB.player_list.len

var/player_count = length(get_active_player_count(alive_check = TRUE))

CheffieGithub · 2026-02-26T21:25:11Z

code/controllers/subsystem/regional_threat.dm

+	for(var/T in threat_regions)
+		var/datum/threat_region/TR = T


Suggested change

for(var/T in threat_regions)

var/datum/threat_region/TR = T

for(var/datum/threat_region/TR as anything in threat_regions)

CheffieGithub · 2026-02-26T21:25:25Z

code/controllers/subsystem/regional_threat.dm

+	for(var/T in threat_regions)
+		var/datum/threat_region/TR = T


Suggested change

for(var/T in threat_regions)

var/datum/threat_region/TR = T

for(var/datum/threat_region/TR as anything in threat_regions)

CheffieGithub · 2026-02-26T21:25:46Z

code/controllers/subsystem/regional_threat.dm

+	for(var/T in threat_regions)
+		var/datum/threat_region/TR = T


Suggested change

for(var/T in threat_regions)

var/datum/threat_region/TR = T

for(var/datum/threat_region/TR as anything in threat_regions)

CheffieGithub · 2026-02-26T21:27:24Z

code/game/area/areas.dm


 	var/converted_type
+
+	var/threat_region = "" // Key used to look up threat region this area belongs to


Tie this to an area typecache instead?

CheffieGithub · 2026-02-26T21:29:26Z

code/game/objects/items/barding.dm

@@ -0,0 +1,104 @@
+/obj/item/clothing/barding


Why is it clothing?

CheffieGithub · 2026-02-26T21:30:21Z

code/game/objects/structures/traveltile.dm

+/obj/structure/fluff/traveltile/proc/resolve_destination_area()
+	if(!aportalgoesto)
+		return
+	for(var/obj/structure/fluff/traveltile/other in GLOB.traveltiles) // or however you iterate portals


Suggested change

for(var/obj/structure/fluff/traveltile/other in GLOB.traveltiles) // or however you iterate portals

for(var/obj/structure/fluff/traveltile/other as anything in GLOB.traveltiles) // or however you iterate portals

CheffieGithub · 2026-02-26T21:31:33Z

code/modules/food_and_drinks/rations.dm

+	grid_height = 32
+	grid_width = 32
+	dropshrink = 0.6
+	var/obj/item/reagent_containers/food/snacks/food = null // The food item wrapped in the ration


CheffieGithub · 2026-02-26T21:32:24Z

code/modules/mob/living/carbon/human/npc/human_soldiers/highwaymen.dm

+
+/mob/living/carbon/human/species/human/northern/highwayman
+	ai_controller = /datum/ai_controller/human_npc
+	faction = list("viking", "station")


Faction defines please?

CheffieGithub · 2026-02-26T21:32:44Z

code/modules/mob/living/carbon/human/npc/human_soldiers/deranged.dm

+
+/mob/living/carbon/human/species/human/northern/deranged_knight
+	ai_controller = /datum/ai_controller/human_npc
+	faction = list("dundead")


dundead or undead?

dwasint added 29 commits February 18, 2026 12:39

Update _automaton.dm

bee97d0

adds in a ghost vessel component so that we can create possessable th…

abdde4c

…ings based on an item attack, adds in craftable automatons

Merge remote-tracking branch 'upstream/main' into revert-removal

572adc1

adds it to the latejoin menu

144644e

Update ghost_vessel.dm

a08fe1d

adds whitelist system that we can use for later adds it to vessels

2164fbd

adds a prefilled variant of the vessel

bba441d

Update ghost_vessel.dm

c56e2c0

Update game.dm

9328b5e

Update vanderlin.dmm

8eace22

adds job boost and roundstart support to vessel targets

cfc3f2a

Update ticker.dm

1c0923c

Update ghost_vessel.dm

194bc9a

Update job_boosts.dm

519059e

Update job_boosts.dm

3e3025f

better

36d06ab

the fuck you mean em dashes don't work we literally have them as a sa…

32934e0

…y mod

bracketed

17635d3

Update admin.dm

58337ad

2 new components forced shutdown and repairable robotics, makes their…

97c71e8

… limbs actually robotic with a bullshit fix to get them to render

Update _component.dm

8e5eeeb

Update _component.dm

e4e4522

whoops

86d1bb3

Update living_defines.dm

1219f63

Update ghost_vessel.dm

df5b92d

radiant quests and reduxed regional threats, improved human npc code

7542a66

Merge remote-tracking branch 'upstream/main' into revert-removal

cfbc99b

,ompr foxes

1e5bb4c

made it more grounded

26cc85c

dwasint requested a review from aberrantQuesrist as a code owner February 22, 2026 10:24

high_value strip prevention

9c53744

VANDERLIN-MONARCH mentioned this pull request Feb 25, 2026

Blood no longer seems to drip into containers. #5400

Open

dwasint added 10 commits February 25, 2026 15:50

compass overhaul to use portal locations aswell

5d6079b

aggro board setting and maneaters don't target clientless

d07f524

Update ambush.dm

c13b584

replaces high_value strip with an element so you can still salvage shit

846d677

whoops

ddb50fe

Update loot.dm

bd12874

this should make it feel more responsive

8dc8136

Update mob_helpers.dm

3cf619b

Update _animal_gene.dm

2e70816

call for help and special attacks, aswell as concurrent processing fo…

003dcc0

…r behaviors that are deemed complmentary. npcs can feint and use stamina I'm low key evil.

github-actions bot added the MERGE CONFLICT This PR has conflicting changes with the main branch and can't be merged label Feb 26, 2026

dwasint added 3 commits February 26, 2026 02:08

Update _base.dm

a8f5c30

Update _base.dm

86eae69

sigh

6287981

github-actions bot removed the MERGE CONFLICT This PR has conflicting changes with the main branch and can't be merged label Feb 26, 2026

VANDERLIN-MONARCH mentioned this pull request Feb 26, 2026

Quest issue #5405

Open

dwasint added 2 commits February 26, 2026 11:45

Update human_basic_attack.dm

a8ab3fb

Update steam_life.dm

cc0a410

This was referenced Feb 26, 2026

Player that was not a deadite suddenly rose as deadite. #5408

Open

Fancy hat has a small pixel in a corner when looking to the west #5409

Open

CheffieGithub reviewed Feb 26, 2026

View reviewed changes

code/game/objects/items/weapons/rmb_intents.dm Show resolved Hide resolved

CheffieGithub reviewed Feb 26, 2026

View reviewed changes

This was referenced Feb 26, 2026

Merchant NPC Hostile #5410

Open

Tiefling insanity #5411

Open

Vampires can get stuff in the dying state in a coffin #5413

Open

Farming Bottle Kit Bug #5414

Open

dwasint added 2 commits February 26, 2026 17:05

adds drag support to canvases

7b5b68a

Update animal_genetics.dm

743cd70

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Quests, Ambush Refactor & Human NPC overhaul#5357

Quests, Ambush Refactor & Human NPC overhaul#5357
dwasint wants to merge 85 commits intoMonkestation:mainfrom
dwasint:revert-removal

dwasint commented Feb 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

CheffieGithub Feb 26, 2026

Uh oh!

CheffieGithub Feb 26, 2026

Uh oh!

CheffieGithub Feb 26, 2026

Uh oh!

CheffieGithub Feb 26, 2026

Uh oh!

CheffieGithub Feb 26, 2026

Uh oh!

CheffieGithub Feb 26, 2026

Uh oh!

CheffieGithub Feb 26, 2026

Uh oh!

CheffieGithub Feb 26, 2026

Uh oh!

CheffieGithub Feb 26, 2026

Uh oh!

CheffieGithub Feb 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	var/player_count = GLOB.player_list.len
	var/player_count = length(get_active_player_count(alive_check = TRUE))

	for(var/T in threat_regions)
	var/datum/threat_region/TR = T
	for(var/datum/threat_region/TR as anything in threat_regions)


		var/converted_type

		var/threat_region = "" // Key used to look up threat region this area belongs to

	for(var/obj/structure/fluff/traveltile/other in GLOB.traveltiles) // or however you iterate portals
	for(var/obj/structure/fluff/traveltile/other as anything in GLOB.traveltiles) // or however you iterate portals

Conversation

dwasint commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

About The Pull Request

Why It's Good For The Game

Changelog

Pre-Merge Checklist

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dwasint commented Feb 22, 2026 •

edited

Loading