Fixes devotion meter not appearing round start#5398
Open
TerraGS wants to merge 3 commits intoMonkestation:mainfrom
Open
Fixes devotion meter not appearing round start#5398TerraGS wants to merge 3 commits intoMonkestation:mainfrom
TerraGS wants to merge 3 commits intoMonkestation:mainfrom
Conversation
| holder_mob.cleric = src | ||
| holder_mob?.hud_used?.initialize_bloodpool() | ||
| holder_mob?.hud_used?.bloodpool.set_fill_color(devotion_color) | ||
| if(holder_mob?.hud_used) |
Collaborator
There was a problem hiding this comment.
Change this to checking if the round is setting up and adding an OnRoundstart callback if it is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Somewhat of a bandaid solution. The problem stems from the devotion meter needing hud_used to be assigned before initializing. For round start jobs devotion gets granted before hud_used is assigned (when mind is transfered to the mob).
This adds a listener for the login signal to attempt to initialize the meter again, which should guarantee hud_used is assigned at this point.
Changelog
🆑
fix: Devotion meter should now appear round start
/:cl:
Pre-Merge Checklist