Skip to content

Keybind QOL#5404

Open
KevinfromHP wants to merge 2 commits intoMonkestation:mainfrom
KevinfromHP:hotkey-issues
Open

Keybind QOL#5404
KevinfromHP wants to merge 2 commits intoMonkestation:mainfrom
KevinfromHP:hotkey-issues

Conversation

@KevinfromHP
Copy link
Collaborator

About The Pull Request

Why It's Good For The Game

Fixes Shift Keybinds, also adjusts the mousewheel to allow for rmb intent cycle

Changelog

🆑
qol: keybind fixes
/:cl:

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

@github-actions github-actions bot added the Quality of Life The hardest thing to decide is if this is NOT a balance change label Feb 26, 2026
for(var/i in 1 to length_char(input_text))
var/i_char = copytext_char(input_text, i, i + 1)
switch(i_char)
if("!") i_char = "1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't you just... disallow these special chars instead of remapping them?

Copy link
Collaborator Author

@KevinfromHP KevinfromHP Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When Shift + 1 is evaluated, its evaluated key in the document script is always going to actually look like Shift + !.
As far as I'm aware there is no way around this. We could take the code instead of the keycode but that's an even bigger pain in the ass

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and as it stands i also didn't find a way to translate these keys to a normalized form in our code / the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Quality of Life The hardest thing to decide is if this is NOT a balance change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants