-
-
Notifications
You must be signed in to change notification settings - Fork 123
Suppress usage reporting in AP mode #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: netmindz <442066+netmindz@users.noreply.github.com>
Co-authored-by: netmindz <442066+netmindz@users.noreply.github.com>
Co-authored-by: netmindz <442066+netmindz@users.noreply.github.com>
as recommended by the rabbit
|
in upstream it's just
|
👌 https://github.com/wled/WLED/blob/4d63b3c8a0569f72cecf177f98ab26c3e733c60a/wled00/json.cpp#L793-L799 I'll check if I can can backport that. Edit: WLED also has the "ap always" mode, which means that both the AP and a normal STA connection could be active at the same time. |
Ah I didn't know about that, what is the use case for that? |
you can now use the same as in upstream. i've added |
long time since I tried that. I think it was for "emergencies" where the device still has the Wifi credentials stored in flash, but you want to use WLED-AP to change that. 🤔 which sounds like some kind of backdoor for exploits tbh 🤣 |
Usage reporting attempts to contact
usage.wled.meduring AP mode when no internet connectivity exists.Changes
Added IP address check in
checkVersionUpgrade()to skip version reporting when device is in AP mode:When
Network.isConnected()is false,info.ipreturns empty string (seejson.cpp:1272). This check prevents the upgrade dialog from appearing when connectivity is unavailable.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.