Introduce liq_cue_skip and fix bugs#37
Open
t0mtaylor wants to merge 5 commits intoMoonbase59:masterfrom
Open
Conversation
…on Mac when writing tags for m4a/mp4 files
Author
|
testing with original |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proposed v4.2.0 with new options:
Reason for change: To allow rerun of
cue_filewithin a script over files sync'd and so it wont reprocess files that have already been processed and taggedThe added benefit of the
liq_cue_skiptag also now stops the file metadata/tags being written again to the media file, which would cause the modified date to change when it doesn't need to. This causes a nightmare for bi-direction sync.Introduce
skiparg andliq_cue_skiptag for files to avoid reprocessing by force, as current logic doesn't seem to work as expected, this is backwards compatible with previously processed files and not a breaking change. Files may require reprocessingone timeto add the new tag where required.The
liq_cue_filemust be true when skip is enabled, to allow Azuracast to read the tags and avoid any more re-processing, - although when true Azuracast outputs:cue_file results override existing metadata because liq_cue_file=true tells us to.which means Azuracast may need to support the skip tag to be forced to just read the tags when this is true.fix Mutagen m4a python TypeError: encoding without a string argument on Mac when writing tags for m4a/mp4 files (should be string).
Add debug flag to allow some additional messages when required
example command line, which includes
write, replygain, skip (-p), debug (-z):./cue_file "filename.mp3" -wrpzforce will still work if required, or you remove skip for existing checks