Skip to content

bugfix(test): bump physicallybased proof + LIVE_TAG default to v2026.04.2 (#250 follow-up) #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gerchowl merged 2 commits into from
Apr 30, 2026
+14 −9
Merged

bugfix(test): bump physicallybased proof + LIVE_TAG default to v2026.04.2 (#250 follow-up) #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc35016
bugfix(ci): bump live-test tag from v2026.04.0 to v2026.04.2 (#249 fo…
gerchowl Apr 30, 2026
2831bfd
bugfix(test): bump physicallybased proof + LIVE_TAG default to v2026.…
gerchowl Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .dagger/src/mat_vis_ci/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ async def test_all(
async def test_client_python(
self,
src: Annotated[dagger.Directory, Doc("Project root directory")] | None = None,
tag: Annotated[str, Doc("Release tag to test against")] = "v2026.04.0",
tag: Annotated[str, Doc("Release tag to test against")] = "v2026.04.2",
live: Annotated[
bool,
Doc("Set MAT_VIS_LIVE_TESTS=1 + MAT_VIS_LIVE_TAG=tag to enable @live tests (#248)"),
Expand Down Expand Up @@ -300,7 +300,7 @@ async def test_client_python(
async def test_client_js(
self,
src: Annotated[dagger.Directory, Doc("Project root directory")] | None = None,
tag: Annotated[str, Doc("Release tag to test against")] = "v2026.04.0",
tag: Annotated[str, Doc("Release tag to test against")] = "v2026.04.2",
live: Annotated[
bool,
Doc("Set MAT_VIS_LIVE_TESTS=1 + MAT_VIS_LIVE_TAG=tag to enable live tests (#248)"),
Expand All @@ -325,7 +325,7 @@ async def test_client_js(
async def test_client_shell(
self,
src: Annotated[dagger.Directory, Doc("Project root directory")] | None = None,
tag: Annotated[str, Doc("Release tag to test against")] = "v2026.04.0",
tag: Annotated[str, Doc("Release tag to test against")] = "v2026.04.2",
live: Annotated[
bool,
Doc("Set MAT_VIS_LIVE_TESTS=1 + MAT_VIS_LIVE_TAG=tag to enable live tests (#248)"),
Expand All @@ -351,7 +351,7 @@ async def test_client_shell(
async def test_client_rust(
self,
src: Annotated[dagger.Directory, Doc("Project root directory")] | None = None,
tag: Annotated[str, Doc("Release tag to test against")] = "v2026.04.0",
tag: Annotated[str, Doc("Release tag to test against")] = "v2026.04.2",
live: Annotated[
bool,
Doc("Set MAT_VIS_LIVE_TESTS=1 + MAT_VIS_LIVE_TAG=tag to enable live tests (#248)"),
Expand Down Expand Up @@ -382,7 +382,7 @@ async def test_client_rust(
async def test_clients(
self,
src: Annotated[dagger.Directory, Doc("Project root directory")] | None = None,
tag: Annotated[str, Doc("Release tag to test against")] = "v2026.04.0",
tag: Annotated[str, Doc("Release tag to test against")] = "v2026.04.2",
live: Annotated[
bool,
Doc("Forward MAT_VIS_LIVE_TESTS=1 + MAT_VIS_LIVE_TAG=tag to every client (#248)"),
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
# in each language container so the @live / liveDescribe blocks
# (incl. the #248 manifest-driven coverage matrix) actually run
# against prod HF, not the structural-only stubs.
args: test-clients --src=. --tag=v2026.04.0 --live=true
args: test-clients --src=. --tag=v2026.04.2 --live=true

# validate-release lives in promote-data-release.yml (pre-promotion gate)
# and release-validate.yml (daily drift check). It tests the state of a
Expand Down
11 changes: 8 additions & 3 deletions clients/python/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1279,7 +1279,7 @@ def test_original_check_caches_at_client_level(self, mock_client):
)


LIVE_TAG = os.environ.get("MAT_VIS_LIVE_TAG", "v2026.04.1")
LIVE_TAG = os.environ.get("MAT_VIS_LIVE_TAG", "v2026.04.2")
LIVE_SOURCE = "polyhaven"
LIVE_TIER = "1k"

Expand Down Expand Up @@ -1358,9 +1358,14 @@ def test_fetch_nonexistent_material_raises(self, live_client):

@live
def test_proof_phase_2_fetch_physicallybased_index_from_hf():
"""Scalar catalog for physicallybased is fetchable from HF substrate."""
"""Scalar catalog for physicallybased is fetchable from HF substrate.

Uses ``LIVE_TAG`` (env-overridable) so this stays current as
the prod release tag rolls forward; #250 surfaced a hardcoded
v2026.04.1 here that broke once that tag was sunset.
"""
with tempfile.TemporaryDirectory() as tmp:
client = MatVisClient(tag="v2026.04.1", cache_dir=Path(tmp))
client = MatVisClient(tag=LIVE_TAG, cache_dir=Path(tmp))
idx = client.index("physicallybased")
assert len(idx) >= 50, f"expected ≥50 PB entries, got {len(idx)}"
assert all("id" in e and "source" in e for e in idx)
Expand Down
Loading