Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions .cursor/commands/create-pr.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,32 +31,43 @@ When creating a pull request, follow these steps:
git rebase main
```

3. **Run pre-commit hooks and tests:**
3. **Ensure all changes are committed:**

```bash
# Ensure all checks pass
git status # Should show clean working directory
git status # Must show "nothing to commit, working tree clean"
```

4. **Self-review your changes:**
- **All work must be committed before creating PR**
- No uncommitted changes allowed
- No untracked files that should be included
- See [git-commit.md](./git-commit.md) for commit guidelines

4. **Run pre-commit hooks and tests:**

```bash
# All pre-commit hooks should have passed during commits
# Verify tests pass if applicable
```

5. **Self-review your changes:**
- Read through the diff
- Check for console.logs, TODOs, or debug code
- Verify all tests pass
- Run pre-commit hooks
- Confirm pre-commit hooks passed

5. **Push your branch:**
6. **Push your branch:**

```bash
git push origin your-branch
```

6. **Create the pull request:**
7. **Create the pull request:**

```bash
gh pr create
```

7. **Fill out the PR template** with:
8. **Fill out the PR template** with:
- Clear, descriptive title
- Detailed description of changes
- Related issues (if applicable)
Expand Down Expand Up @@ -176,6 +187,7 @@ Examples:

Before creating PR, ensure:

- **All changes are committed** (clean working directory)
- Branch follows naming convention
- Commits follow conventional format
- All pre-commit hooks pass
Expand Down
Loading
Loading