bug fix to not include timezone additions#150
Open
Elyahu41 wants to merge 1 commit intoMosheBerman:masterfrom
Open
bug fix to not include timezone additions#150Elyahu41 wants to merge 1 commit intoMosheBerman:masterfrom
Elyahu41 wants to merge 1 commit intoMosheBerman:masterfrom
Conversation
MosheBerman
requested changes
Dec 28, 2023
Owner
MosheBerman
left a comment
MosheBerman
left a comment
There was a problem hiding this comment.
when the timezone changes the next or previous day
What do you mean by this? Do you have an example where this behavior impacts the code negatively?
Owner
This is correct. |
Contributor
Author
Try to see what happens in your app for November 5th, 2023. You will see that the times are incorrect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that happens when the timezone changes the next or previous day. The only problem this fix might present is accuracy, as not every day is 84,000 seconds from what I remember.