Add Button component#22
Merged
Mossop merged 2 commits intoMossop:mainfrom Sep 26, 2025
medusalix:button
Merged
Conversation
Mossop
requested changes
Sep 25, 2025
Owner
Mossop
left a comment
Mossop
left a comment
There was a problem hiding this comment.
This looks ok. I don't want to get too specific with the errors but I agree that IOError isn't right, how about adding an Error::Invalid?
Also can you remove the command_topic from the light component as it wouldn't be needed any longer?
Owner
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a button component for Home Assistant (see docs here). Buttons require a
command_topicinstead of astate_topic, so I've decided to make both of these fields optional for theEntitystruct.One thing I'm not quite sure about is if returning
Error::IOErroris a good idea when anEntitydoesn't have astate_topic. It might make sense to introduce a new error type for that, what do you think?