Skip to content

Revert "fix(restore-session): re-send AddInvoice for failed payments on session restore"#722

Merged
grunch merged 1 commit intomainfrom
revert-721-fix/restore-session-failed-payment-601
Apr 29, 2026
Merged

Revert "fix(restore-session): re-send AddInvoice for failed payments on session restore"#722
grunch merged 1 commit intomainfrom
revert-721-fix/restore-session-failed-payment-601

Conversation

@grunch
Copy link
Copy Markdown
Member

@grunch grunch commented Apr 29, 2026

Reverts #721

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

Warning

Rate limit exceeded

@grunch has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 44 minutes and 28 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0955a4e3-52b3-4613-acf0-d7980a1eef8c

📥 Commits

Reviewing files that changed from the base of the PR and between 87ff37b and 872f9d5.

📒 Files selected for processing (2)
  • src/app/restore_session.rs
  • src/db.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-721-fix/restore-session-failed-payment-601

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 44 minutes and 28 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 872f9d591d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 59 to 63
if let Err(e) = send_restore_session_response(
&trade_key,
&master_key,
result.restore_orders,
result.restore_disputes,
pool.clone(),
)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore AddInvoice resend for failed payments

This revert drops the only restore-session path that re-queues Action::AddInvoice for orders stuck in settled-hold-invoice with failed_payment=true. In the current flow, send_restore_session_response now only sends RestoreData, so if the buyer was offline when the original failure notification was emitted, reconnecting via restore-session will not trigger the invoice re-prompt and that order can remain blocked until manual intervention. Please keep restore-session tied to failed-payment lookup so those buyers reliably receive the retry prompt after reconnect.

Useful? React with 👍 / 👎.

@grunch grunch merged commit 48e59ea into main Apr 29, 2026
8 checks passed
@grunch grunch deleted the revert-721-fix/restore-session-failed-payment-601 branch April 29, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant