Skip to content

removed langchain#4

Open
simbolmina wants to merge 1 commit intoMpcsj-Computing:stagingfrom
simbolmina:main
Open

removed langchain#4
simbolmina wants to merge 1 commit intoMpcsj-Computing:stagingfrom
simbolmina:main

Conversation

@simbolmina
Copy link

  • I removed langchain and made adjustments chatHistoryManager and moved it into utils folder.
  • added a feature to add a initial prompt
  • removed first chat-gpt module since I did not want to update it.
  • updated and used latest openai library
  • I was gonna ask you to create separate branch for this use this however you want.

@simbolmina
Copy link
Author

I guess this won't work for more than 1 user and db integration will be required. I am working on one for production and it will take some time.

@Mpcsj-Computing
Copy link
Owner

Hello, thank you so much for contributing to the project! I just created a new branch called staging. Is it okay to merge your code there instead of main? So main branch can be aligned with the video content in case someone else wants to double-check their code while watching the videos.

So if it's okay, we can rebranch this PR to staging, instead of main

Comment on lines +2 to +23
// parser: '@typescript-eslint/parser',
// parserOptions: {
// project: 'tsconfig.json',
// sourceType: 'module',
// },
// plugins: ['@typescript-eslint/eslint-plugin'],
// extends: [
// 'plugin:@typescript-eslint/recommended',
// 'plugin:prettier/recommended',
// ],
// root: true,
// env: {
// node: true,
// jest: true,
// },
// ignorePatterns: ['.eslintrc.js'],
// rules: {
// '@typescript-eslint/interface-name-prefix': 'off',
// '@typescript-eslint/explicit-function-return-type': 'off',
// '@typescript-eslint/explicit-module-boundary-types': 'off',
// '@typescript-eslint/no-explicit-any': 'off',
// },
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this lint file is not required, could you please delete this file?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this lint file is not required, could you please delete this file?

yeah again. i usually start uninstalling and deleting eslint since TS does all the work. I dont know why ppl use it in TS projects generally.

@Mpcsj-Computing
Copy link
Owner

I guess this won't work for more than 1 user and db integration will be required. I am working on one for production and it will take some time.

Awesome! Let me know if you want some help

@simbolmina
Copy link
Author

Hello, thank you so much for contributing to the project! I just created a new branch called staging. Is it okay to merge your code there instead of main? So main branch can be aligned with the video content in case someone else wants to double-check their code while watching the videos.

So if it's okay, we can rebranch this PR to staging, instead of main

yeah sure. it wont take long to create another PR. But to personalize each chat we will need a user so authentication etc. I'm also feeding ai with personal info of the user as well. Maybe i can create some dummy data for this project. My project is way complicated currently and i'll strip most of the code for this one, like my first PR.

@Mpcsj-Computing
Copy link
Owner

Mpcsj-Computing commented Sep 22, 2023

Hello, thank you so much for contributing to the project! I just created a new branch called staging. Is it okay to merge your code there instead of main? So main branch can be aligned with the video content in case someone else wants to double-check their code while watching the videos.
So if it's okay, we can rebranch this PR to staging, instead of main

yeah sure. it wont take long to create another PR. But to personalize each chat we will need a user so authentication etc. I'm also feeding ai with personal info of the user as well. Maybe i can create some dummy data for this project. My project is way complicated currently and i'll strip most of the code for this one, like my first PR.

Yeah, actually you don't need to create another PR. You can change the base branch directly on Github this way:

  1. On the PR page, on top right, click Edit
Screenshot 2023-09-22 at 08 17 46
  1. Then you change the destination branch from main to another one, like staging
Screenshot 2023-09-22 at 08 18 03
---- Screenshot 2023-09-22 at 08 18 46

@simbolmina simbolmina changed the base branch from main to staging September 22, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants