ec/google/chromeec: Add support for After G3 State, and enable it for FIZZ #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to selectively enable After G3 State syncing, which can be used to sync coreboot user selected after G3 behavior (CFR) to ChromeEC at boot via custom host command EC_CMD_AFTER_G3_STATE. Without this, ChromeEC will always use default compiled after G3 behavior (usually "Previous State"). Tested on FIZZ/SION. Signed-off-by: Lukasz Kutyla <9387698+movr4x@users.noreply.github.com>
Signed-off-by: Lukasz Kutyla <9387698+movr4x@users.noreply.github.com>
movr4x
force-pushed
the
MrChromebox-2509-ag3s-up
branch
from
6fe79ee to
7428c24
Compare
MrChromebox
reviewed
Dec 5, 2025
MrChromebox
reviewed
Dec 5, 2025
MrChromebox
reviewed
Dec 5, 2025
Signed-off-by: Lukasz Kutyla <9387698+movr4x@users.noreply.github.com>
Signed-off-by: Lukasz Kutyla <9387698+movr4x@users.noreply.github.com>
Signed-off-by: Lukasz Kutyla <9387698+movr4x@users.noreply.github.com>
Author
|
I have tried to address the issues and reworked for simplicity. If you can, please check if all of it is ok with you. While it compiles without problem, I still need to test this on my device, so please do not merge this yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to selectively enable After G3 State syncing, which can be used to sync coreboot user selected after G3 behavior (CFR) to ChromeEC at boot via custom host command
EC_CMD_AFTER_G3_STATE.Without this, ChromeEC will always use default compiled after G3 behavior (usually "Previous State"), overriding coreboot CFR.
Tested on FIZZ/SION.
This should fix the following issues (requires ChromeEC patch to work, separate PR):
MrChromebox/firmware#766
MrChromebox/firmware#669
MrChromebox/firmware#831
FIZZ ChromeEC AG3S PR:
MrChromebox/chrome-ec#11
Support for
EC_CMD_AFTER_G3_STATEin coreboot can be also re-used by other boards, as long as EC is patched to handleEC_CMD_AFTER_G3_STATE. All it takes to enable syncing attempt is addingCONFIG_CHROMEEC_AFTER_G3_STATE=yto target boardconfigs/**/*.uefi.