This repository was archived by the owner on Dec 23, 2020. It is now read-only.
Fixed ExporterJavaCode having incorrect values and class name#162
Open
peter1745 wants to merge 3 commits intoMrCrayfish:masterfrom
peter1745:master
Open
Fixed ExporterJavaCode having incorrect values and class name#162peter1745 wants to merge 3 commits intoMrCrayfish:masterfrom peter1745:master
peter1745 wants to merge 3 commits intoMrCrayfish:masterfrom
peter1745:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExporterJavaCode was giving the Block.makeCuboidShape incorrect values, since they should be multiplied with 16, because Block.makeCuboidShape divides all values by 16 internally.
ShapeUtils is called VoxelShapes in forge 1.13.
Fixes #161