Skip to content

refactor: shared DeviceFrame primitive, fix phone-in-phone on wallet page#15

Merged
nathanialhenniges merged 2 commits intomainfrom
claude/ecstatic-joliot
Apr 15, 2026
Merged

refactor: shared DeviceFrame primitive, fix phone-in-phone on wallet page#15
nathanialhenniges merged 2 commits intomainfrom
claude/ecstatic-joliot

Conversation

@nathanialhenniges
Copy link
Copy Markdown
Member

Summary

  • Fix: Wallet admin page was rendering two nested iPhone frames (phone-in-phone) around the wallet pass preview
  • Add: New DeviceFrame primitive — reusable iPhone shell (status bar, dynamic island, signal/wifi/battery, parallax scroll, height="auto" for content-sized) with no framework coupling
  • Refactor: PhoneFrame reduced to thin wrapper over DeviceFrame, preserving PreviewProvider + 512→328 scale for public-page previews (appearance, builder) — no breaking changes
  • Refactor: WalletPassPreview stripped to content-only pass card; all device chrome removed

What changed

File Change
apps/web/src/components/admin/device-frame.tsx New — low-level iPhone shell primitive
apps/web/src/components/admin/phone-frame.tsx Thin wrapper over DeviceFrame; moved StatusBar, useCurrentTime, PreviewSkeleton into DeviceFrame
apps/web/src/components/admin/wallet-pass-preview.tsx Dropped outer w-[340px] wrapper + rounded card shell; now returns pass card content only
apps/web/src/app/admin/wallet/page.tsx Replaced ad-hoc inline frame with <DeviceFrame width={300} height="auto" previewDark>

Reviewer notes

  • PhoneFrame API is unchanged — PreviewRenderer, SharedPreview, MobilePreviewSheet need zero changes
  • Wallet preview uses height="auto" (no scroll, no parallax); appearance/builder keep height={570} with parallax via PhoneFrame
  • Dark frame on wallet page is intentional (previewDark always true — wallet pass sits on dark background)

🤖 Generated with Claude Code

nathanialhenniges and others added 2 commits April 15, 2026 04:58
… page

- Add shared DeviceFrame component (device shell + status bar + dynamic island)
- Refactor PhoneFrame to thin wrapper over DeviceFrame (public-page preview)
- Strip WalletPassPreview to content-only card (no device chrome)
- Replace inline frame on wallet page with DeviceFrame width=300 height=auto

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 15, 2026

Warning

Rate limit exceeded

@nathanialhenniges has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 51 minutes and 55 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 51 minutes and 55 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 16984b33-4000-48cd-95ba-803e454a9a92

📥 Commits

Reviewing files that changed from the base of the PR and between d322087 and a126dcf.

📒 Files selected for processing (4)
  • apps/web/src/app/admin/wallet/page.tsx
  • apps/web/src/components/admin/device-frame.tsx
  • apps/web/src/components/admin/phone-frame.tsx
  • apps/web/src/components/admin/wallet-pass-preview.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/ecstatic-joliot

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nathanialhenniges nathanialhenniges merged commit b6c7200 into main Apr 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant