Conversation
…ditionally, so we can either now pass a file name, or actual data to the solver via the parameter handler. For this we created another parameter in the parameter handler that stores the vectors.
…t. Now instead of passing data via the parameter handler, we do it via a Solver constructor. We also remove the check file from CheckParameters and added the new constructor to solver.h
Collaborator
Author
|
For now we have our pymurtree setup pointing to develop branch so our current pymurtree main branch should work |
missing imports for mingw compiler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @EmirDe and @kjgm, these are the changes needed for murtree C++ to be used by pymurtree.
There are a couple of enhancements including:
@yiquintero let me know if there is something missing.