Add tools to select edges by arrow-shapes, line-color and line-style#340
Add tools to select edges by arrow-shapes, line-color and line-style#340HitRam wants to merge 1 commit intoMurali-group:developfrom
Conversation
|
Thanks for this contribution, @HitRam. Adding selection by line style will also be valuable. Please implement this selection criterion. |
HitRam
changed the title
|
@tmmurali, I also implemented selection by line-style. |
adbharadwaj
left a comment
adbharadwaj
left a comment
There was a problem hiding this comment.
I requested few changes.
static/js/graphs_page.js
Outdated
| original_opacity: {}, | ||
| undoRedoManager: null, | ||
| init: function () { | ||
| cytoscapeGraph.hideGraphInformation(graphPage.cyGraph); |
There was a problem hiding this comment.
Why do we need to hide and show graph information?
static/js/graphs_page.js
Outdated
| /* | ||
| Function to Show information about the graph that the layout editor hid from the users. | ||
| */ | ||
| console.log(cy.style().selector('node')); |
There was a problem hiding this comment.
Can you remove the log.
There was a problem hiding this comment.
Yeah sure! Actually I was initially making changes on master branch and these lines were already there.
static/js/graphs_page.js
Outdated
| }); | ||
|
|
||
| $('#nodeLabel').on('input', function (e) { | ||
| console.log(!_.isEmpty($('#nodeLabel').val())); |
There was a problem hiding this comment.
Comment out the console log.
|
@adbharadwaj I have changed as requested. Initially I was making changes in master branch and those logs were already there so didn't notice while switching the branches. |
3 participants
I have added tools to select edges by arrow-shapes and line-color.
Should I also add an option to select it by line-style?
This PR refers to #308