Added a Save Layout button on the Layouts pane#411
Merged
adbharadwaj merged 2 commits intoMurali-group:developfrom Apr 30, 2019
Merged
Added a Save Layout button on the Layouts pane#411adbharadwaj merged 2 commits intoMurali-group:developfrom
adbharadwaj merged 2 commits intoMurali-group:developfrom
Conversation
Contributor
Author
|
Ping @adbharadwaj @jlaw9 |
Collaborator
|
Looks great to me. Can you change the title of the layout pop-up to "Save Positions and Style" and add the description "Save the current x- and y-coordinates of every node and the style attributes of every node and edge." to the pop-up? This is from #271 |
Contributor
Author
|
@jlaw9 Thanks for the review. I'll update my PR soon. |
lohani2280
force-pushed
the
save_layout_branch
branch
from
759e17c to
1210855
Compare
Contributor
Author
|
@jlaw9 Updated the PR as suggested. I have also attached the screenshot of the layout pop-up. Please have a look.
|
Collaborator
|
Thanks looks good. Ideally this button would be able to save just the x- and y-coordinates as that's all you can change in this mode, but I think that can wait for a different issue. |
Contributor
Author
|
Exactly. Even I was thinking that in this mode one can only save the x-and y-coordinates and not the styles. |
jahandaniyal
reviewed
Feb 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adding a "Save Layout" button on the Layouts pane
Fixes #392
In the gif below, I have tried to demonstrate the above solution
Approach
On pressing the "Save Layout" button, a dialogue box asking to save the layout pops up and the user can now directly save the layout generated without entering the Layout Editor and immediately exiting out.
Open Questions and Pre-Merge TODOs